eric/onix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #614 from ssd532/fix/test-failures

Browse Source 
Fix test failures in reqmapper and simplekeymanager plugins
This commit is contained in:
Mayuresh A Nirhali
2026-03-02 17:30:53 +05:30
committed by GitHub
parent 01f959a25b 34954ce83a
commit fe541227b9
3 changed files with 7 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
pkg/plugin/implementation/reqmapper/cmd/plugin_test.go
View File

@@ -11,7 +11,8 @@ import (
func TestProviderNewSuccess(t *testing.T) { func TestProviderNewSuccess(t *testing.T) {
p := provider{} p := provider{}
middleware, err := p.New(context.Background(), map[string]string{"role": "bap"}) mappingFile := "../testdata/mappings.yaml"
middleware, err := p.New(context.Background(), map[string]string{"role": "bap", "mappingsFile": mappingFile})
if err != nil { if err != nil {
t.Fatalf("provider.New returned unexpected error: %v", err) t.Fatalf("provider.New returned unexpected error: %v", err)
} }

11
pkg/plugin/implementation/simplekeymanager/cmd/plugin_test.go
View File

@@ -76,7 +76,7 @@ func TestSimpleKeyManagerProvider_New(t *testing.T) {
config: map[string]string{ config: map[string]string{
"keyId": "test-key", "keyId": "test-key",
}, },
wantErr: false, wantErr: true,
}, },
} }
@@ -145,14 +145,13 @@ func TestConfigMapping(t *testing.T) {
cache := &mockCache{} cache := &mockCache{}
registry := &mockRegistry{} registry := &mockRegistry{}
// Test config mapping
configMap := map[string]string{ configMap := map[string]string{
"networkParticipant": "mapped-np", "networkParticipant": "mapped-np",
"keyId": "mapped-key-id", "keyId": "mapped-key-id",
"signingPrivateKey": "mapped-signing-private", "signingPrivateKey": "dGVzdC1zaWduaW5nLXByaXZhdGU=",
"signingPublicKey": "mapped-signing-public", "signingPublicKey": "dGVzdC1zaWduaW5nLXB1YmxpYw==",
"encrPrivateKey": "mapped-encr-private", "encrPrivateKey": "dGVzdC1lbmNyLXByaXZhdGU=",
"encrPublicKey": "mapped-encr-public", "encrPublicKey": "dGVzdC1lbmNyLXB1YmxpYw==",
} }
// We can't directly test the config mapping without exposing internals, // We can't directly test the config mapping without exposing internals,

4
pkg/plugin/implementation/simplekeymanager/simplekeymanager_test.go
View File

@@ -181,10 +181,6 @@ func TestGenerateKeyset(t *testing.T) {
return return
} }
// Check that all fields are populated
if keyset.SubscriberID == "" {
t.Error("GenerateKeyset() SubscriberID is empty")
}
if keyset.UniqueKeyID == "" { if keyset.UniqueKeyID == "" {
t.Error("GenerateKeyset() UniqueKeyID is empty") t.Error("GenerateKeyset() UniqueKeyID is empty")
} }