eric/onix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: privatekey method change (#442)

Browse Source
This commit is contained in:
rupinder-syngh
2025-03-31 22:38:36 +05:30
committed by GitHub
parent f7e66b0911
commit f41e41266a
2 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
pkg/plugin/implementation/signer/signer.go
View File

@@ -48,11 +48,12 @@ func generateSignature(signingString []byte, privateKeyBase64 string) ([]byte, e
return nil, fmt.Errorf("error decoding private key: %w", err) return nil, fmt.Errorf("error decoding private key: %w", err)
} }
if len(privateKeyBytes) != ed25519.PrivateKeySize { if len(privateKeyBytes) != ed25519.SeedSize {
return nil, errors.New("invalid private key length") return nil, errors.New("invalid seed length")
} }
privateKey := ed25519.PrivateKey(privateKeyBytes) // Generate the private key from the seed
privateKey := ed25519.NewKeyFromSeed(privateKeyBytes)
return ed25519.Sign(privateKey, signingString), nil return ed25519.Sign(privateKey, signingString), nil
} }

4
pkg/plugin/implementation/signer/signer_test.go
View File

@@ -12,7 +12,7 @@ import (
// generateTestKeys generates a test private and public key pair in base64 encoding. // generateTestKeys generates a test private and public key pair in base64 encoding.
func generateTestKeys() (string, string) { func generateTestKeys() (string, string) {
publicKey, privateKey, _ := ed25519.GenerateKey(nil) publicKey, privateKey, _ := ed25519.GenerateKey(nil)
return base64.StdEncoding.EncodeToString(privateKey), base64.StdEncoding.EncodeToString(publicKey) return base64.StdEncoding.EncodeToString(privateKey.Seed()), base64.StdEncoding.EncodeToString(publicKey)
} }
// TestSignSuccess tests the Sign method with valid inputs to ensure it produces a valid signature. // TestSignSuccess tests the Sign method with valid inputs to ensure it produces a valid signature.
@@ -82,7 +82,7 @@ func TestSignFailure(t *testing.T) {
privateKey: base64.StdEncoding.EncodeToString([]byte("short_key")), privateKey: base64.StdEncoding.EncodeToString([]byte("short_key")),
createdAt: time.Now().Unix(), createdAt: time.Now().Unix(),
expiresAt: time.Now().Unix() + 3600, expiresAt: time.Now().Unix() + 3600,
expectErrString: "invalid private key length", expectErrString: "invalid seed length",
}, },
} }