fix: resolved comments

This commit is contained in:
mayur.popli
2025-03-26 09:39:37 +05:30
parent 543f100dfe
commit f13157b6b9
6 changed files with 39 additions and 51 deletions

View File

@@ -1,27 +0,0 @@
mode: set
github.com/beckn/beckn-onix/pkg/model/error.go:15.32,17.2 1 1
github.com/beckn/beckn-onix/pkg/model/error.go:23.46,25.31 2 1
github.com/beckn/beckn-onix/pkg/model/error.go:25.31,27.3 1 1
github.com/beckn/beckn-onix/pkg/model/error.go:28.2,28.42 1 1
github.com/beckn/beckn-onix/pkg/model/error.go:31.51,32.24 1 1
github.com/beckn/beckn-onix/pkg/model/error.go:32.24,37.3 1 0
github.com/beckn/beckn-onix/pkg/model/error.go:38.2,40.31 3 1
github.com/beckn/beckn-onix/pkg/model/error.go:40.31,41.22 1 1
github.com/beckn/beckn-onix/pkg/model/error.go:41.22,43.4 1 1
github.com/beckn/beckn-onix/pkg/model/error.go:44.3,44.43 1 1
github.com/beckn/beckn-onix/pkg/model/error.go:47.2,51.3 1 1
github.com/beckn/beckn-onix/pkg/model/error.go:58.72,60.2 1 1
github.com/beckn/beckn-onix/pkg/model/error.go:62.55,64.2 1 1
github.com/beckn/beckn-onix/pkg/model/error.go:66.49,71.2 1 1
github.com/beckn/beckn-onix/pkg/model/error.go:77.41,79.2 1 1
github.com/beckn/beckn-onix/pkg/model/error.go:81.56,83.2 1 1
github.com/beckn/beckn-onix/pkg/model/error.go:85.41,90.2 1 1
github.com/beckn/beckn-onix/pkg/model/error.go:96.45,98.2 1 1
github.com/beckn/beckn-onix/pkg/model/error.go:100.60,102.2 1 1
github.com/beckn/beckn-onix/pkg/model/error.go:104.43,109.2 1 1
github.com/beckn/beckn-onix/pkg/model/model.go:63.71,65.45 2 0
github.com/beckn/beckn-onix/pkg/model/model.go:65.45,67.3 1 0
github.com/beckn/beckn-onix/pkg/model/model.go:69.2,70.23 2 0
github.com/beckn/beckn-onix/pkg/model/model.go:70.23,72.3 1 0
github.com/beckn/beckn-onix/pkg/model/model.go:73.2,74.12 2 0
github.com/beckn/beckn-onix/pkg/model/model.go:93.61,95.2 1 0

View File

@@ -6,20 +6,24 @@ import (
"strings"
)
// Error represents an error response.
type Error struct {
Code string `json:"code"`
Paths string `json:"paths,omitempty"`
Message string `json:"message"`
}
// Error implements the error interface for the Error struct.
func (e *Error) Error() string {
return fmt.Sprintf("Error: Code=%s, Path=%s, Message=%s", e.Code, e.Paths, e.Message)
}
// SchemaValidationErr represents a collection of schema validation failures.
type SchemaValidationErr struct {
Errors []Error
}
// Error implements the error interface for SchemaValidationErr.
func (e *SchemaValidationErr) Error() string {
var errorMessages []string
for _, err := range e.Errors {
@@ -35,6 +39,8 @@ func (e *SchemaValidationErr) BecknError() *Error {
Message: "Schema validation error.",
}
}
// Collect all error paths and messages
var paths []string
var messages []string
for _, err := range e.Errors {
@@ -51,6 +57,7 @@ func (e *SchemaValidationErr) BecknError() *Error {
}
}
// SignalidationErr represents a collection of schema validation failures.
type SignValidationErr struct {
error
}
@@ -70,6 +77,7 @@ func (e *SignValidationErr) BecknError() *Error {
}
}
// SignalidationErr represents a collection of schema validation failures.
type BadReqErr struct {
error
}
@@ -89,6 +97,7 @@ func (e *BadReqErr) BecknError() *Error {
}
}
// SignalidationErr represents a collection of schema validation failures.
type NotFoundErr struct {
error
}

View File

@@ -19,8 +19,10 @@ func TestError_Error(t *testing.T) {
actual := err.Error()
if actual != expected {
t.Errorf("expected %s, got %s", expected, actual)
t.Errorf("err.Error() = %s, want %s",
actual, expected)
}
}
func TestSchemaValidationErr_Error(t *testing.T) {
@@ -35,7 +37,8 @@ func TestSchemaValidationErr_Error(t *testing.T) {
actual := schemaErr.Error()
if actual != expected {
t.Errorf("expected %s, got %s", expected, actual)
t.Errorf("err.Error() = %s, want %s",
actual, expected)
}
}
@@ -49,7 +52,8 @@ func TestSchemaValidationErr_BecknError(t *testing.T) {
beErr := schemaErr.BecknError()
expected := "Bad Request"
if beErr.Code != expected {
t.Errorf("expected %s, got %s", expected, beErr.Code)
t.Errorf("err.Error() = %s, want %s",
beErr.Code, expected)
}
}
@@ -59,15 +63,18 @@ func TestSignValidationErr_BecknError(t *testing.T) {
expectedMsg := "Signature Validation Error: signature failed"
if beErr.Message != expectedMsg {
t.Errorf("expected %s, got %s", expectedMsg, beErr.Message)
t.Errorf("err.Error() = %s, want %s",
beErr.Message, expectedMsg)
}
}
func TestNewSignValidationErrf(t *testing.T) {
signErr := NewSignValidationErrf("error %s", "signature failed")
expected := "error signature failed"
if signErr.Error() != expected {
t.Errorf("expected %s, got %s", expected, signErr.Error())
t.Errorf("err.Error() = %s, want %s",
signErr.Error(), expected)
}
}
@@ -76,7 +83,8 @@ func TestNewSignValidationErr(t *testing.T) {
signErr := NewSignValidationErr(err)
if signErr.Error() != err.Error() {
t.Errorf("expected %s, got %s", err.Error(), signErr.Error())
t.Errorf("err.Error() = %s, want %s", err.Error(),
signErr.Error())
}
}

View File

@@ -36,7 +36,7 @@ const (
type contextKey string
var MsgIDKey = contextKey("message_id")
const MsgIDKey = contextKey("message_id")
type Role string