eric/onix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: resolved comments

Browse Source
This commit is contained in:
mayur.popli
2025-03-26 12:10:56 +05:30
parent 61ad817bc2
commit c254a669e8
1 changed files with 3 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
pkg/response/response.go
View File

@@ -33,15 +33,11 @@ func SendAck(w http.ResponseWriter) {
}, },
} }
data, err := json.Marshal(resp) data, _ := json.Marshal(resp) //should not fail here
if err != nil {
http.Error(w, "failed to marshal response", http.StatusInternalServerError)
return
}
w.Header().Set("Content-Type", "application/json") w.Header().Set("Content-Type", "application/json")
w.WriteHeader(http.StatusOK) w.WriteHeader(http.StatusOK)
_, err = w.Write(data) _, err := w.Write(data)
if err != nil { if err != nil {
http.Error(w, "failed to write response", http.StatusInternalServerError) http.Error(w, "failed to write response", http.StatusInternalServerError)
return return
@@ -57,12 +53,7 @@ func nack(w http.ResponseWriter, err *model.Error, status int, ctx context.Conte
Error: err, Error: err,
}, },
} }
data, jsonErr := json.Marshal(resp) data, _ := json.Marshal(resp) //should not fail here
if jsonErr != nil {
fmt.Printf("Error marshaling response: %v, MessageID: %s", jsonErr, ctx.Value(model.MsgIDKey))
http.Error(w, fmt.Sprintf("Internal server error, MessageID: %s", ctx.Value(model.MsgIDKey)), http.StatusInternalServerError)
return
}
w.Header().Set("Content-Type", "application/json") w.Header().Set("Content-Type", "application/json")
w.WriteHeader(status) w.WriteHeader(status)