eric/onix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

updated code as per the review comment

Browse Source 
1. changed struct to httpConfig
2. Removed initLogger func var
3. Removed mocked registryClient from registry test code
This commit is contained in:
MohitKatare-protean
2025-04-01 15:26:38 +05:30
parent 450f13cf34
commit b879cb8faa
3 changed files with 15 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
core/module/client/registry_test.go
View File

@@ -13,16 +13,6 @@ import (
"github.com/stretchr/testify/require"
)
// MockRegistryClient is a mock implementation of the RegistryClient.
type MockRegistryClient struct {
SubscribeFunc func(ctx context.Context, subscription *model.Subscription) error
}
// Subscribe calls the mock Subscribe function.
func (m *MockRegistryClient) Subscribe(ctx context.Context, subscription *model.Subscription) error {
return m.SubscribeFunc(ctx, subscription)
}
// TestSubscribeSuccess verifies that the Subscribe function succeeds when the server responds with HTTP 200.
func TestSubscribeSuccess(t *testing.T) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
@@ -84,11 +74,11 @@ func TestSubscribeFailure(t *testing.T) {
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
mockClient := &MockRegistryClient{
SubscribeFunc: func(ctx context.Context, subscription *model.Subscription) error {
return tt.mockError
},
}
client := NewRegisteryClient(&Config{
RetryMax: 1,
RetryWaitMin: 1 * time.Millisecond,
RetryWaitMax: 2 * time.Millisecond,
})
subscription := &model.Subscription{
KeyID: "test-key",
@@ -103,7 +93,7 @@ func TestSubscribeFailure(t *testing.T) {
subscription = &model.Subscription{} // Example of an invalid object
}
err := mockClient.Subscribe(context.Background(), subscription)
err := client.Subscribe(context.Background(), subscription)
require.Error(t, err) // Directly checking for an error since all cases should fail
})
}
@@ -217,7 +207,7 @@ func TestLookupFailure(t *testing.T) {
config := &Config{
RegisteryURL: server.URL,
RetryMax: 0, // Prevent excessive retries
RetryMax: 0,
RetryWaitMin: 1 * time.Millisecond,
RetryWaitMax: 2 * time.Millisecond,
}