fix: shared renamed to pkg, formatting changes

This commit is contained in:
rupinder-syngh
2025-03-20 11:33:20 +05:30
parent ed046d9ce4
commit a606d385f4
16 changed files with 14 additions and 40 deletions

View File

@@ -0,0 +1,51 @@
package main
import (
"context"
"fmt"
"github.com/beckn/beckn-onix/pkg/plugin/definition"
"github.com/beckn/beckn-onix/pkg/plugin/implementation/publisher"
)
// Returns error if required fields are missing.
func validateConfig(config map[string]string) (*publisher.Config, error) {
if config == nil {
return nil, fmt.Errorf("config cannot be nil")
}
project, ok := config["project"]
if !ok || project == "" {
return nil, fmt.Errorf("project ID is required")
}
topic, ok := config["topic"]
if !ok || topic == "" {
return nil, fmt.Errorf("topic ID is required")
}
return &publisher.Config{
ProjectID: project,
TopicID: topic,
}, nil
}
// PublisherProvider implements the definition.PublisherProvider interface.
type PublisherProvider struct{}
// New creates a new Publisher instance.
func (p PublisherProvider) New(ctx context.Context, config map[string]string) (definition.Publisher, error) {
if ctx == nil {
return nil, fmt.Errorf("context cannot be nil")
}
cfg, err := validateConfig(config)
if err != nil {
return nil, fmt.Errorf("invalid config: %w", err)
}
return publisher.New(ctx, cfg)
}
// Provider is the exported symbol that the plugin manager will look for.
var Provider definition.PublisherProvider = PublisherProvider{}

View File

@@ -0,0 +1,74 @@
package main
import (
"context"
"testing"
"github.com/beckn/beckn-onix/pkg/plugin/definition"
)
// MockPublisher is a mock implementation of the definition.Publisher interface for testing.
type MockPublisher struct{}
func (m *MockPublisher) Publish(ctx context.Context, msg []byte) error {
return nil
}
func (m *MockPublisher) Close() error {
return nil
}
// TestValidateConfig tests the validateConfig function.
func TestValidateConfig(t *testing.T) {
tests := []struct {
name string
config map[string]string
wantErr bool
}{
{"Valid config", map[string]string{"project": "test-project", "topic": "test-topic"}, false},
{"Nil config", nil, true},
{"Missing project", map[string]string{"topic": "test-topic"}, true},
{"Missing topic", map[string]string{"project": "test-project"}, true},
{"Empty project", map[string]string{"project": "", "topic": "test-topic"}, true},
{"Empty topic", map[string]string{"project": "test-project", "topic": ""}, true},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
_, err := validateConfig(tt.config)
if (err != nil) != tt.wantErr {
t.Errorf("validateConfig() error = %v, wantErr %v", err, tt.wantErr)
}
})
}
}
// TestPublisherProviderNew tests the New method of PublisherProvider.
func TestPublisherProviderNew(t *testing.T) {
tests := []struct {
name string
ctx context.Context
config map[string]string
wantErr bool
}{
{"Nil context", nil, map[string]string{"project": "test-project", "topic": "test-topic"}, true},
{"Invalid config", context.Background(), map[string]string{"project": "", "topic": "test-topic"}, true},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
provider := PublisherProvider{}
_, err := provider.New(tt.ctx, tt.config)
if (err != nil) != tt.wantErr {
t.Errorf("PublisherProvider.New() error = %v, wantErr %v", err, tt.wantErr)
}
})
}
}
// TestProviderImplementation verifies that the Provider is correctly initialized.
func TestProviderImplementation(t *testing.T) {
if _, ok := interface{}(Provider).(definition.PublisherProvider); !ok {
t.Errorf("Provider does not implement definition.PublisherProvider")
}
}