Update on review comments

1. changed implementations from camelcase to lowercase
2. added removed initSteps.
3. updated rout struct for model.go
This commit is contained in:
MohitKatare-protean
2025-03-29 16:08:28 +05:30
parent 98c04b1f9f
commit 9bfb65079e
9 changed files with 77 additions and 17 deletions

View File

@@ -81,9 +81,9 @@ func (r *Role) UnmarshalYAML(unmarshal func(interface{}) error) error {
// Route represents a network route for message processing.
type Route struct {
Type string
URL *url.URL
Publisher string
TargetType string // "url" or "msgq" or "bap" or "bpp"
PublisherID string // For message queues
URL *url.URL // For API calls
}
// StepContext holds context information for a request processing step.

View File

@@ -5,7 +5,7 @@ import (
"net/http"
"strings"
requestpreprocessor "github.com/beckn/beckn-onix/pkg/plugin/implementation/requestPreProcessor"
"github.com/beckn/beckn-onix/pkg/plugin/implementation/requestpreprocessor"
)
type provider struct{}

View File

@@ -4,8 +4,8 @@ import (
"context"
"errors"
definition "github.com/beckn/beckn-onix/pkg/plugin/definition"
schemaValidator "github.com/beckn/beckn-onix/pkg/plugin/implementation/schemavalidator"
"github.com/beckn/beckn-onix/pkg/plugin/definition"
"github.com/beckn/beckn-onix/pkg/plugin/implementation/schemavalidator"
)
// schemaValidatorProvider provides instances of schemaValidator.
@@ -24,7 +24,7 @@ func (vp schemaValidatorProvider) New(ctx context.Context, config map[string]str
}
// Create a new schemaValidator instance with the provided configuration
return schemaValidator.New(ctx, &schemaValidator.Config{
return schemavalidator.New(ctx, &schemavalidator.Config{
SchemaDir: schemaDir,
})
}

View File

@@ -5,8 +5,7 @@ import (
"errors"
"github.com/beckn/beckn-onix/pkg/plugin/definition"
verifier "github.com/beckn/beckn-onix/pkg/plugin/implementation/signVerifier"
"github.com/beckn/beckn-onix/pkg/plugin/implementation/signverifier"
)
// VerifierProvider provides instances of Verifier.
@@ -18,7 +17,7 @@ func (vp VerifierProvider) New(ctx context.Context, config map[string]string) (d
return nil, nil, errors.New("context cannot be nil")
}
return verifier.New(ctx, &verifier.Config{})
return signverifier.New(ctx, &signverifier.Config{})
}
// Provider is the exported symbol that the plugin manager will look for.

View File

@@ -1,4 +1,4 @@
package verifier
package signverifier
import (
"context"

View File

@@ -1,4 +1,4 @@
package verifier
package signverifier
import (
"context"