Issue 540 - fix: remove hardcoded value and add test cases

This commit is contained in:
ameersohel45
2025-10-29 12:20:31 +05:30
parent ffdd94e16a
commit 5bd485d189
5 changed files with 252 additions and 288 deletions

View File

@@ -21,7 +21,8 @@ func (d dediRegistryProvider) New(ctx context.Context, config map[string]string)
// Create dediregistry.Config directly from map - validation is handled by dediregistry.New
dediConfig := &dediregistry.Config{
BaseURL: config["baseURL"],
URL: config["url"],
RegistryName: config["registryName"],
}
// Parse timeout if provided

View File

@@ -10,11 +10,8 @@ func TestDediRegistryProvider_New(t *testing.T) {
provider := dediRegistryProvider{}
config := map[string]string{
"baseURL": "https://test.com",
"apiKey": "test-key",
"namespaceID": "test-namespace",
"registryName": "test-registry",
"recordName": "test-record",
"url": "https://test.com/dedi",
"registryName": "subscribers.beckn.one",
"timeout": "30",
}
@@ -47,12 +44,12 @@ func TestDediRegistryProvider_New_InvalidConfig(t *testing.T) {
config map[string]string
}{
{
name: "missing baseURL",
config: map[string]string{"apiKey": "test-key"},
name: "missing url",
config: map[string]string{"registryName": "subscribers.beckn.one", "timeout": "30"},
},
{
name: "missing apiKey",
config: map[string]string{"baseURL": "https://test.com"},
name: "missing registryName",
config: map[string]string{"url": "https://test.com/dedi", "timeout": "30"},
},
{
name: "empty config",
@@ -75,11 +72,8 @@ func TestDediRegistryProvider_New_InvalidTimeout(t *testing.T) {
provider := dediRegistryProvider{}
config := map[string]string{
"baseURL": "https://test.com",
"apiKey": "test-key",
"namespaceID": "test-namespace",
"registryName": "test-registry",
"recordName": "test-record",
"url": "https://test.com/dedi",
"registryName": "subscribers.beckn.one",
"timeout": "invalid",
}
@@ -95,3 +89,20 @@ func TestDediRegistryProvider_New_InvalidTimeout(t *testing.T) {
closer()
}
}
func TestDediRegistryProvider_New_NilContext(t *testing.T) {
provider := dediRegistryProvider{}
config := map[string]string{
"url": "https://test.com/dedi",
"registryName": "subscribers.beckn.one",
}
_, _, err := provider.New(nil, config)
if err == nil {
t.Error("New() with nil context should return error")
}
if err.Error() != "context cannot be nil" {
t.Errorf("Expected specific error message, got %v", err)
}
}