updated code as per the review comments

This commit is contained in:
MohitKatare-protean
2025-04-01 12:31:43 +05:30
parent 2fe39a2c0a
commit 450f13cf34
4 changed files with 45 additions and 92 deletions

View File

@@ -246,8 +246,6 @@ func (h *stdHandler) initSteps(ctx context.Context, mgr PluginManager, cfg *Conf
s, err = newValidateSchemaStep(h.schemaValidator)
case "addRoute":
s, err = newAddRouteStep(h.router)
case "broadcast":
s = &broadcastStep{}
default:
if customStep, exists := steps[step]; exists {
s = customStep

View File

@@ -167,12 +167,3 @@ func (s *addRouteStep) Run(ctx *model.StepContext) error {
}
return nil
}
// broadcastStep is a stub implementation of a step that handles broadcasting messages.
type broadcastStep struct{}
// Run executes the broadcast step.
func (b *broadcastStep) Run(ctx *model.StepContext) error {
// TODO: Implement broadcast logic if needed
return nil
}

View File

@@ -69,45 +69,33 @@ func (m *mockPluginManager) SchemaValidator(ctx context.Context, cfg *plugin.Con
// TestRegisterSuccess tests scenarios where the handler registration should succeed.
func TestRegisterSuccess(t *testing.T) {
tests := []struct {
name string
mCfgs []Config
mockManager *mockPluginManager
}{
mCfgs := []Config{
{
name: "successful registration",
mCfgs: []Config{
{
Name: "test-module",
Path: "/test",
Handler: handler.Config{
Type: handler.HandlerTypeStd,
Plugins: handler.PluginCfg{
Middleware: []plugin.Config{{ID: "mock-middleware"}},
},
},
},
},
mockManager: &mockPluginManager{
middlewareFunc: func(ctx context.Context, cfg *plugin.Config) (func(http.Handler) http.Handler, error) {
return func(next http.Handler) http.Handler {
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
next.ServeHTTP(w, r)
})
}, nil
Name: "test-module",
Path: "/test",
Handler: handler.Config{
Type: handler.HandlerTypeStd,
Plugins: handler.PluginCfg{
Middleware: []plugin.Config{{ID: "mock-middleware"}},
},
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
mux := http.NewServeMux()
err := Register(context.Background(), tt.mCfgs, mux, tt.mockManager)
if err != nil {
t.Errorf("unexpected error: %v", err)
}
})
mockManager := &mockPluginManager{
middlewareFunc: func(ctx context.Context, cfg *plugin.Config) (func(http.Handler) http.Handler, error) {
return func(next http.Handler) http.Handler {
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
next.ServeHTTP(w, r)
})
}, nil
},
}
mux := http.NewServeMux()
err := Register(context.Background(), mCfgs, mux, mockManager)
if err != nil {
t.Errorf("unexpected error: %v", err)
}
}