fix: module id and linting issues

This commit is contained in:
mayur.popli
2025-04-04 15:39:05 +05:30
parent d1e8716e15
commit 2329efd562
7 changed files with 13 additions and 7 deletions

View File

@@ -7,6 +7,7 @@ import (
"github.com/beckn/beckn-onix/core/module/handler"
"github.com/beckn/beckn-onix/pkg/log"
"github.com/beckn/beckn-onix/pkg/model"
)
// Config represents the configuration for a module.
@@ -75,7 +76,7 @@ func addMiddleware(ctx context.Context, mgr handler.PluginManager, handler http.
func moduleCtxMiddleware(moduleName string, next http.Handler) http.Handler {
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
ctx := context.WithValue(r.Context(), "module_name", moduleName)
ctx := context.WithValue(r.Context(), model.ContextKeyModuleId, moduleName)
next.ServeHTTP(w, r.WithContext(ctx))
})
}

View File

@@ -8,6 +8,7 @@ import (
"testing"
"github.com/beckn/beckn-onix/core/module/handler"
"github.com/beckn/beckn-onix/pkg/model"
"github.com/beckn/beckn-onix/pkg/plugin"
"github.com/beckn/beckn-onix/pkg/plugin/definition"
)
@@ -106,7 +107,7 @@ func TestRegisterSuccess(t *testing.T) {
// Create a handler that extracts context
var capturedModuleName any
testHandler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
capturedModuleName = r.Context().Value("module_name")
capturedModuleName = r.Context().Value(model.ContextKeyModuleId)
w.WriteHeader(http.StatusOK)
})
@@ -115,7 +116,7 @@ func TestRegisterSuccess(t *testing.T) {
// Now verify if module name exists in context
if capturedModuleName != "test-module" {
t.Errorf("expected module_name in context to be 'test-module', got %v", capturedModuleName)
t.Errorf("expected module_id in context to be 'test-module', got %v", capturedModuleName)
}
}