eric/onix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Resolved PR review comments

Browse Source
This commit is contained in:
MohitKatare-protean
2025-05-28 11:25:11 +05:30
parent 3ebf4e9815
commit 1db8aa48ac
5 changed files with 55 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/plugin/implementation/keymanager/cmd/plugin.go
View File

@@ -17,8 +17,8 @@ var newKeyManagerFunc = keymanager.New
// New creates and initializes a new KeyManager instance using the provided cache, registry lookup, and configuration.
func (k *keyManagerProvider) New(ctx context.Context, cache definition.Cache, registry definition.RegistryLookup, cfg map[string]string) (definition.KeyManager, func() error, error) {
config := &keymanager.Config{
VaultAddr: cfg["vault_addr"],
KVVersion: cfg["kv_version"],
VaultAddr: cfg["vaultAddr"],
KVVersion: cfg["kvVersion"],
}
log.Debugf(ctx, "Keymanager config mapped: %+v", cfg)
km, cleanup, err := newKeyManagerFunc(ctx, cache, registry, config)

8
pkg/plugin/implementation/keymanager/cmd/plugin_test.go
View File

@@ -62,8 +62,8 @@ func TestNewSuccess(t *testing.T) {
cache := &mockCache{}
registry := &mockRegistry{}
cfg := map[string]string{
"vault_addr": "http://dummy-vault",
"kv_version": "2",
"vaultAddr": "http://dummy-vault",
"kvVersion": "2",
}
cleanupCalled := false
@@ -105,8 +105,8 @@ func TestNewFailure(t *testing.T) {
cache := &mockCache{}
registry := &mockRegistry{}
cfg := map[string]string{
"vault_addr": "http://dummy-vault",
"kv_version": "2",
"vaultAddr": "http://dummy-vault",
"kvVersion": "2",
}
newKeyManagerFunc = func(ctx context.Context, cache definition.Cache, registry definition.RegistryLookup, cfg *keymanager.Config) (*keymanager.KeyMgr, func() error, error) {