eric/onix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

update the as per the comment

Browse Source
This commit is contained in:
Manendra Pal Singh
2025-12-15 12:12:33 +05:30
parent c367a970d1
commit 17d9ca865d
8 changed files with 96 additions and 81 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
pkg/plugin/implementation/otelsetup/cmd/plugin_test.go
View File

@@ -56,7 +56,7 @@ func TestMetricsProviderNew_Success(t *testing.T) {
require.NoError(t, err, "New() should not return error")
require.NotNil(t, telemetryProvider, "New() should return non-nil provider")
// Test cleanup function if it exists
// Metrics server is started inside provider when enabled; MetricsHandler is not exposed.
if cleanup != nil {
err := cleanup()
assert.NoError(t, err, "cleanup() should not return error")
@@ -165,12 +165,6 @@ func TestMetricsProviderNew_ConfigConversion(t *testing.T) {
require.NoError(t, err, "New() should not return error")
require.NotNil(t, telemetryProvider, "New() should return non-nil provider")
// Verify that the provider was created (we can't directly check internal config,
// but we can verify the provider is functional)
if tt.expectedConfig.EnableMetrics {
assert.NotNil(t, telemetryProvider.MetricsHandler, "MetricsHandler should be set when metrics enabled")
}
if cleanup != nil {
err := cleanup()
assert.NoError(t, err, "cleanup() should not return error")
@@ -231,11 +225,6 @@ func TestMetricsProviderNew_BooleanParsing(t *testing.T) {
require.NoError(t, err, "New() should not return error")
require.NotNil(t, telemetryProvider, "New() should return non-nil provider")
// Verify metrics handler is set based on enableMetrics
if tt.expected {
assert.NotNil(t, telemetryProvider.MetricsHandler, "MetricsHandler should be set when metrics enabled")
}
if cleanup != nil {
err := cleanup()
assert.NoError(t, err, "cleanup() should not return error")
@@ -300,9 +289,6 @@ func TestMetricsProviderNew_DefaultValues(t *testing.T) {
require.NoError(t, err, "New() should not return error with empty config")
require.NotNil(t, telemetryProvider, "New() should return non-nil provider")
// Verify defaults are applied by checking that provider is functional
assert.NotNil(t, telemetryProvider.MetricsHandler, "MetricsHandler should be set with defaults")
if cleanup != nil {
err := cleanup()
assert.NoError(t, err, "cleanup() should not return error")