update on the review comments

This commit is contained in:
MohitKatare-protean
2025-04-08 16:28:33 +05:30
parent cf4b397249
commit 0a210d4f31
4 changed files with 13 additions and 14 deletions

View File

@@ -45,18 +45,18 @@ func (c *registryClient) Subscribe(ctx context.Context, subscription *model.Subs
req, err := retryablehttp.NewRequest("POST", subscribeURL, bytes.NewBuffer(jsonData))
if err != nil {
return model.NewBadReqErr(fmt.Errorf("failed to create request: %w", err))
return fmt.Errorf("failed to create request: %w", err)
}
req.Header.Set("Content-Type", "application/json")
resp, err := c.client.Do(req)
if err != nil {
return model.NewBadReqErr(fmt.Errorf("failed to send request with retry: %w", err))
return fmt.Errorf("failed to send request with retry: %w", err)
}
defer resp.Body.Close()
if resp.StatusCode != http.StatusOK {
return model.NewBadReqErr(fmt.Errorf("subscribe request failed with status: %s", resp.Status))
return fmt.Errorf("subscribe request failed with status: %s", resp.Status)
}
return nil
}
@@ -72,23 +72,23 @@ func (c *registryClient) Lookup(ctx context.Context, subscription *model.Subscri
req, err := retryablehttp.NewRequest("POST", lookupURL, bytes.NewBuffer(jsonData))
if err != nil {
return nil, model.NewBadReqErr(fmt.Errorf("failed to create request: %w", err))
return nil, fmt.Errorf("failed to create request: %w", err)
}
req.Header.Set("Content-Type", "application/json")
resp, err := c.client.Do(req)
if err != nil {
return nil, model.NewBadReqErr(fmt.Errorf("failed to send request with retry: %w", err))
return nil, fmt.Errorf("failed to send request with retry: %w", err)
}
defer resp.Body.Close()
if resp.StatusCode != http.StatusOK {
return nil, model.NewBadReqErr(fmt.Errorf("lookup request failed with status: %s", resp.Status))
return nil, fmt.Errorf("lookup request failed with status: %s", resp.Status)
}
body, err := io.ReadAll(resp.Body)
if err != nil {
return nil, model.NewBadReqErr(fmt.Errorf("failed to read response body: %w", err))
return nil, fmt.Errorf("failed to read response body: %w", err)
}
var results []model.Subscription